[Minor]: support window functions in order by expressions#20963
Open
buraksenn wants to merge 2 commits intoapache:mainfrom
Open
[Minor]: support window functions in order by expressions#20963buraksenn wants to merge 2 commits intoapache:mainfrom
buraksenn wants to merge 2 commits intoapache:mainfrom
Conversation
alamb
approved these changes
Mar 24, 2026
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thanks @buraksenn and @haohuaijin -- this also looks good to me
I had one suggestion / request for the test but otherwise looks good
fyi @jonahgao as our resident SQL planner expert in case you have time to review as well
| @@ -0,0 +1,91 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
Contributor
There was a problem hiding this comment.
Rather than adding a new test file, can you please integrate this into one of the existing files (window.slt or orderby.slt perhaps?)
Contributor
Author
There was a problem hiding this comment.
I was thinking since it is a new feature and intersection I can create a test file will do of course. I've moved them to window.slt. Thanks for the review @alamb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
#608 has details but as @alamb describes in #608 (comment)
fails with:
What changes are included in this PR?
Are these changes tested?
Yes added both unit tests for plan and slt tests for checking output
Are there any user-facing changes?
Additive user changes that users can now use window in order by expressions